Add Python interfaces based on nanobind #796
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eature/python-nanobind
Collaborator
Steven-Roberts
left a comment
Steven-Roberts
left a comment
There was a problem hiding this comment.
I think the function tables need to have their deconstructor manually called before the free. I suggested a fix for the case of an error in the create function. The other free occurs when the integrator is destroyed. Perhaps in the wrapping view deconstructor we can manually call the deconstructor of the function table. I'm struggling to see where else this can be called because it has to be in a C++ file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sundials4py, which is a Python interface to SUNDIALS.
The generator code can be found here: https://github.com/sundials-codes/sundials4py-generate.
Rendered docs: https://sundials--796.org.readthedocs.build/en/796/.
Review Requests
@drreynolds:
doc/bindings/sundials4py/arkodebindings/sundials4py/idasbindings/sundials4py/kinsolbindings/sundials4py/sundomeigestbindings/sundials4py/sunlinsolbindings/sundials4py/sunmatrixbindings/sundials4py/examples@gardner48:
Everything but can skip:
_generated.hppfiles (Steven and I will review these)bindings/sundials4py/examples(Steven and Dan are both reviewing these)bindings/sundials4py/arkode(Steven and Dan both reviewing these)bindings/sundials4py/idas(Steven and Dan both reviewing these)@Steven-Roberts
_generated.hppfiles inbindings/sundials4pybindings/sundials4py/arkodebindings/sundials4py/idasbindings/sundials4py/includebindings/sundials4py/sundialsbindings/sundials4py/nvectorbindings/sundials4py/sunadaptcontrollerbindings/sundials4py/sunadjointcheckpointschemebindings/sundials4py/sunnonlinsolbindings/sundials4py/sunmemorybindings/sundials4py/examples